izaya/collapseos
1
0
Fork 0
mirror of https://github.com/hsoft/collapseos.git synced 2025-04-05 06:38:40 +11:00
Code Issues Releases Wiki Activity

Replaced some nop's

Browse Source 
There were some doubled up nop's, so I replaced them with paired pushes and pops, saving 4 bytes and wasting 2-3 extra cycles over the original nop's, so there shouldn't be a problem with not waiting long enough.
This commit is contained in:
Clanmaster21 2019-10-17 20:12:22 +01:00 committed by GitHub
parent 8926c33ab1
commit a2598a4498
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
kernel/sms/kbd.asm
View File

@ -19,8 +19,7 @@ smskbdFetchKCA:
; Port A TH output, low ; Port A TH output, low
ld a, 0b11011101 ld a, 0b11011101
out (0x3f), a out (0x3f), a
nop push hl ; nop, pairs with a pop later
nop
in a, (0xdc) in a, (0xdc)
; bit 3:0 are our dest bits 3:0. handy... ; bit 3:0 are our dest bits 3:0. handy...
and 0b00001111 and 0b00001111
@ -28,8 +27,7 @@ smskbdFetchKCA:
; Port A TH output, high ; Port A TH output, high
ld a, 0b11111101 ld a, 0b11111101
out (0x3f), a out (0x3f), a
nop pop hl ; nop, and matches with push
nop
in a, (0xdc) in a, (0xdc)
; bit 3:0 are our dest bits 7:4 ; bit 3:0 are our dest bits 7:4
rlca \ rlca \ rlca \ rlca rlca \ rlca \ rlca \ rlca
@ -59,8 +57,7 @@ smskbdFetchKCB:
; Port B TH output, low ; Port B TH output, low
ld a, 0b01110111 ld a, 0b01110111
out (0x3f), a out (0x3f), a
nop push hl ; nop, matches with pop later
nop
in a, (0xdc) in a, (0xdc)
; bit 7:6 are our dest bits 1:0 ; bit 7:6 are our dest bits 1:0
rlca \ rlca rlca \ rlca
@ -75,8 +72,7 @@ smskbdFetchKCB:
; Port B TH output, high ; Port B TH output, high
ld a, 0b11110111 ld a, 0b11110111
out (0x3f), a out (0x3f), a
nop pop hl ; nop, matches earlier push
nop
in a, (0xdc) in a, (0xdc)
; bit 7:6 are our dest bits 5:4 ; bit 7:6 are our dest bits 5:4
rrca \ rrca rrca \ rrca