izaya/collapseos
1
0
Fork 0
mirror of https://github.com/hsoft/collapseos.git synced 2025-04-05 06:38:40 +11:00
Code Issues Releases Wiki Activity

use the zero flag to signal success

Browse Source
This commit is contained in:
Valentin Lenhart 2019-11-04 19:04:01 +01:00
parent 5a826de1ee
commit 9f23d7a79c
4 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
apps/at28w/main.asm
View File

@ -14,8 +14,7 @@ at28wMain:
ld de, .argspecs ld de, .argspecs
ld ix, AT28W_MAXBYTES ld ix, AT28W_MAXBYTES
call parseArgs call parseArgs
cp 0xff jr z, at28wInner
jr nz, at28wInner
; bad args ; bad args
ld a, SHELL_ERR_BAD_ARGS ld a, SHELL_ERR_BAD_ARGS
ret ret

3
apps/zasm/main.asm
View File

@ -27,8 +27,7 @@ zasmMain:
ld de, .argspecs ld de, .argspecs
ld ix, ZASM_RAMSTART ld ix, ZASM_RAMSTART
call parseArgs call parseArgs
cp 0xff jr z, .goodargs
jr nz, .goodargs
; bad args ; bad args
ld hl, 0 ld hl, 0
ld de, 0 ld de, 0

3
kernel/parse.asm
View File

@ -163,9 +163,10 @@ parseArgs:
.success: .success:
ld a, PARSE_ARG_MAXCOUNT ld a, PARSE_ARG_MAXCOUNT
sbc a, b sbc a, b
cp a ; set z to signal success
jr .end jr .end
.error: .error:
ld a, 0xff ld a, 1
.end: .end:
pop ix pop ix
pop hl pop hl

3
kernel/shell.asm
View File

@ -155,8 +155,7 @@ shellParse:
; We're ready to parse args ; We're ready to parse args
ld ix, SHELL_CMD_ARGS ld ix, SHELL_CMD_ARGS
call parseArgs call parseArgs
cp 0xff jr nz, .parseerror
jr z, .parseerror
; Args parsed, now we can load the routine address and call it. ; Args parsed, now we can load the routine address and call it.
ld b, a ; pass number of arguments as b ld b, a ; pass number of arguments as b