From c613f7b0ee1d3606928c557cdbb8b509957c4d21 Mon Sep 17 00:00:00 2001 From: Virgil Dupras Date: Fri, 14 Jun 2019 16:30:01 -0400 Subject: [PATCH] recipes/rc2014/eeprom: fix broken a28w args passing That's why the command seemed slow! It's much faster than I thought. --- apps/at28w/main.asm | 6 +++--- recipes/rc2014/eeprom/README.md | 4 ++-- recipes/rc2014/eeprom/glue.asm | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/apps/at28w/main.asm b/apps/at28w/main.asm index 98a9568..a483a1c 100644 --- a/apps/at28w/main.asm +++ b/apps/at28w/main.asm @@ -26,7 +26,7 @@ at28wInner: ld b, h ld c, l ld hl, AT28W_MEMSTART - call at28BCZero + call at28wBCZero jr nz, .loop ; BC is zero, default to 0x2000 (8x, the size of the AT28) ld bc, 0x2000 @@ -55,7 +55,7 @@ at28wInner: jr nz, .mismatch inc hl dec bc - call at28BCZero + call at28wBCZero jr nz, .loop .loopend: @@ -67,7 +67,7 @@ at28wInner: ld a, AT28W_ERR_MISMATCH ret -at28BCZero: +at28wBCZero: xor a cp b ret nz diff --git a/recipes/rc2014/eeprom/README.md b/recipes/rc2014/eeprom/README.md index 39b1108..cc9c047 100644 --- a/recipes/rc2014/eeprom/README.md +++ b/recipes/rc2014/eeprom/README.md @@ -66,8 +66,8 @@ as at argument to `a28w`. You can run: > seek 00 0000 > a28w -It takes a while to write. About 1 second per byte (soon, I'll implement page -writing which should make it much faster). +It takes a little while to write. About 1 second per 0x100 bytes (soon, I'll +implement page writing which should make it much faster). If the program doesn't report an error, you're all good! The program takes care of verifying each byte, so everything should be in place. You can verify diff --git a/recipes/rc2014/eeprom/glue.asm b/recipes/rc2014/eeprom/glue.asm index c2560ce..c38f4ec 100644 --- a/recipes/rc2014/eeprom/glue.asm +++ b/recipes/rc2014/eeprom/glue.asm @@ -62,7 +62,7 @@ init: jp shellLoop a28wCmd: - .db "a28w", 0b011, 0b001 + .db "a28w", 0b011, 0b001, 0 ld a, (hl) ld (AT28W_MAXBYTES+1), a inc hl