From ab4fca334da31e83aedc616a1fb5531eb0e18f6c Mon Sep 17 00:00:00 2001 From: Clanmaster21 Date: Sun, 20 Oct 2019 23:56:31 +0100 Subject: [PATCH] Fixed erroring out for all number >0x1999 I fixed the errors for numbers >0x1999, sadly it is now 6 bytes bigger, so 5 bytes larger than the original, but the speed increases should still hold. --- apps/lib/parse.asm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/apps/lib/parse.asm b/apps/lib/parse.asm index c129dd5..d561311 100644 --- a/apps/lib/parse.asm +++ b/apps/lib/parse.asm @@ -17,8 +17,8 @@ ; same conditions as parseLiteral. ; Sets Z on success, unset on error. -; 55 bytes -; 107 cycles overhead + up to 45 cycles if length >= 5 +; 61 bytes +; 107 cycles overhead + up to 73 cycles if length >= 5 ; 136 cycles in loop ; first digit is skipped in overhead parseDecimal: @@ -63,6 +63,12 @@ parseDecimal: add hl, de ex de, hl jr nc, .loop ; if it doesn't carry, it's small enough + + exx + inc hl + ld a, (hl) + exx + add a, 0xd0 .error: sub 0xd0 ; if a is null, set Z ; a is checked for null before any errors